Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: guichan - Portable C++ GUI library for games using Allegro, SDL and OpenGL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=195692 hugo@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From hugo@xxxxxxxxxxxx 2006-06-16 12:53 EST ------- ------- Additional Comments From wart@xxxxxxxxxx 2006-06-10 00:44 EST ------- MUST ==== * name matches upstream * BSD license ok, license file included * Spec file legible and in Am. English * Sources match upstream: f68b6c603c4fb3d70a8737f916214a35 guichan-0.4.0-src.tar.gz * No excessive BR: * Owns all directories that it creates * No duplicate %files * file permissions look ok * Not relocatable * ldconfig called where needed * macro use consistent * headers and unversioned .so files in -devel package * RPM_BUILD_ROOT cleaned where needed * No .la files * no -doc subpackage needed * devel require base using fully versioned dependency * No .desktop file needed * Compiles and builds on: FC4-i386, FC4-x86_64, FC5-i386, FC5-x86_64 MUSTFIX ======= * Remove the leading 'A' from the summary * Remove the empty Requires: line * Add the following in %prep to prevent the trigger of calls to autoxxx: touch aclocal.m4 Makefile.in */Makefile.in */*/Makefile.in */*/*/Makefile.in touch include/config.hpp.in QUESTIONS ========= * why the 'cp -a' in %prep? Just use %doc docs/html/* to pick up all of the files. - Doesn't compile on FC-6 due to missing autoxxx. The 'touch' commands above should fix that. ------- Additional Comments From hugo@xxxxxxxxxxxx 2006-06-10 12:19 EST ------- Package Updated: Spec URL: http://www.devin.com.br/eitch/rpm/fedora/SPECS/guichan.spec SRPM URL: http://www.devin.com.br/eitch/rpm/fedora/5/SRPMS/guichan-0.4.0-2.src.rpm Changes: - Using libGL-devel instead of mesa-libGL-devel in BuildRequires - Put documentation under -devel instead of a whole -doc - Touch "autoxxx" files to take out autoxxx commands use in devel - Add proper location do doc files (/usr/share/doc/xxx/html) Notes: Took out the cp -a command and get a %doc docs/html intead of docs/html/*. This should put documentation in proper place. ------- Additional Comments From wart@xxxxxxxxxx 2006-06-11 21:35 EST ------- All MUSTFIX items fixed. I learned another trick on f-e-l to fix the autoxxx issue. Instead of touching all of the Makefiles, you can restore the original timestamps on configure/configure.in with: touch -r configure configure.stamp touch -r configure.in configure.in.stamp %patch -p1 touch -r configure.stamp configure touch -r configure.in.stamp configure.in No need to change this before checking in, but's it's good to know for future reference. APPROVED ------- Additional Comments From hugo@xxxxxxxxxxxx 2006-06-11 22:43 EST ------- Package imported and built into devel. Closing. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review