Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ganglia - Ganglia Distributed Monitoring System https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193846 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-06-15 12:21 EST ------- The latest rpmlint output: W: ganglia-devel no-dependency-on ganglia W: ganglia-devel no-documentation E: ganglia-gmetad non-standard-uid /var/lib/ganglia/rrds ganglia E: ganglia-gmetad non-standard-gid /var/lib/ganglia/rrds ganglia W: ganglia-gmetad incoherent-init-script-name gmetad W: ganglia-gmond incoherent-init-script-name gmond All of which are OK. Is the license really BSD? It doesn't seem to have the no-endorsement clause. I'd just call it MIT but I'll leave it up to you. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. ? license field matches the actual license. * license is open source-compatible. License text included in package. * source files match upstream: c48320a112db20e8372ae8e89d97583e ganglia-3.0.3.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (x86_64, development). * rpmlint has only ignorable complaints. * final provides and requires are sane: ganglia-devel-3.0.3-7.fc6.x86_64.rpm libganglia-3.0.3.so.0()(64bit) ganglia-devel = 3.0.3-7.fc6 = /bin/sh /sbin/ldconfig libganglia-3.0.3.so.0()(64bit) ganglia-gmetad-3.0.3-7.fc6.x86_64.rpm config(ganglia-gmetad) = 3.0.3-7.fc6 ganglia-gmetad = 3.0.3-7.fc6 = /bin/sh config(ganglia-gmetad) = 3.0.3-7.fc6 librrd.so.2()(64bit) ganglia-gmond-3.0.3-7.fc6.x86_64.rpm config(ganglia-gmond) = 3.0.3-7.fc6 ganglia-gmond = 3.0.3-7.fc6 = /bin/sh config(ganglia-gmond) = 3.0.3-7.fc6 ganglia-web-3.0.3-7.fc6.x86_64.rpm config(ganglia-web) = 3.0.3-7.fc6 ganglia-web = 3.0.3-7.fc6 = config(ganglia-web) = 3.0.3-7.fc6 ganglia-gmetad >= 3.0.3 rrdtool * shared libraries are present; ldconfig is called properly. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present; no test suite upstream. * scriptlets present (ldconfig); all OK. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers present in -devel package. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. * web app; files are in /usr/share/%{name} APPROVED; I'll let you decide what the license tag should be. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review