Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qjackctl - Qt based JACK control application https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191239 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-06-15 05:55 EST ------- Unfortunatly I cannot do a proper review because the srpm link gives a 404 error, here are some initial MUST fix items from looking at the spec-file: * %makeinstall is broken (yeah I know, someone should fix it) please use: make install DESTDIR=$RPM_BUILD_ROOT instead. (Or make that %{__make} ......) * Under %files I see %{_datadir}/icons/qjackctl.png, that is not according to the freedesktop.org icon standard, it should go under: %{_datadir}/icons/hicolor/32x32/apps Where 32x32 is the size of the icon, please do ls /usr/share/icons/hicolor/ to see the available valid sizes, if the icon doesn't match any pick the closest. * Once the icon is in the proper case you must add %post(un) script to update the icon-cache see: http://fedoraproject.org/wiki/ScriptletSnippets#head-fc74f078205565f961f6d836b77c3428619c689d -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review