Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pam_pkcs11 : PKCS #11 PAM login module https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=165899 ------- Additional Comments From rstrode@xxxxxxxxxx 2006-06-14 18:00 EST ------- Hi Bob, - I'm not sure what our policy on Epoch is (whether to explicitly list it or not when it's 0), but you might want to check that. - You might want to %define macros for the version numbers in your dependencies - You require automake but you don't use it - You might want to follow the more standard %patchN -p1 -b .description convention for patch lines - Should we standardize on an nss dir? maybe /etc/pki/nss or something? I think there is some precedent here, but I don't know what it is. - make_hash_link.sh is a horrible name for something in %{_bindir}, can we rename it or move it to libexecdir or something? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review