Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: knetstats https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193929 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-06-14 03:44 EST ------- Good job on restoring those lost comments! About the review, I've taken a quick glance at: Spec URL: http://beta.glwb.info/knetstats/knetstats.spec And you don't properly update the icon cache, the correctway is: touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ]; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi And yes you need the gtk-update-icon-cache for KDE-apps too, because you want the icon to show properly in the gnome applications menu. About the dangling symlink, that dir is provided by kdelibs: [hans@shalem ~]$ rpm -qf /usr/share/doc/HTML/en/common kdelibs-3.5.3-4.x86_64 Your package should automaticly require kdelibs because of .so dependencies, but in this case you could explicitly Require it, or better perhaps you could add a: Requires: /usr/share/doc/HTML/en/common Please post a new version with these things fixed and then I'll do a full review (and sponsor you once this package is approved). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review