Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 sdake@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO_REPORTER |ASSIGNED ------- Additional Comments From sdake@xxxxxxxxxx 2006-06-13 11:30 EST ------- (In reply to comment #50) > Review > ====== > > rpmlint output: > > E: openais non-readable /usr/sbin/ais-keygen 0700 > E: openais non-standard-executable-perm /usr/sbin/ais-keygen 0700 > (required permissions) > > W: openais non-standard-dir-in-usr libexec > (not *that* non-standard) > > W: openais incoherent-subsys /etc/rc.d/init.d/openais $prog > (daemon and package name are incoherent upstream) > > W: openais-devel conffile-without-noreplace-flag /etc/ld.so.conf.d/openais-i686.conf > (is anyone *really* going to edit this file anyway?) > > I don't believe any of these are blockers, or even need fixing. > > - package and spec file naming OK > - package meets guidelines > - license is BSD, matches spec, text included > - spec file written in ENglish and is legible > - sources match upstream > - builds OK in mock for rawhide (i386) > - buildreqs OK > - no locale-specific data > - shared libraries present in -devel package (only needed for devel) > ldconfig is properly called in %post and %postun for the devel package > - not relocatable > - no directory ownership or permissions issues > - no duplicate files > - %clean section present and correct > - macro usage is consistent > - code, not content > - documentation volume not excessive > - docs don't affect runtime > - header files properly located in -devel package > - static libraries disabled > - no pkgconfig file > - -devel package has fully-versioned dependency on main package > - no libtool archives included > - not a GUI application, so no desktop file needed > - scriptlets are sane > > Issues > ====== > > - package is ExclusiveArch: i386 ppc x86_64 ppc64 > Since this covers all current Fedora Core architectures, why is it present? > > - please correct confusing 0.76-1.6 changelog entry (Comment #48) > > Once these are addressed, I'll be in a position where I'd be happy to approve > this package if it was for Fedora Extras, However, I cannot approve Core > packages, so someone else will need to do that. Paul Thank you for your review. I've updated the package as follows: * Tue Jun 13 2006 Steven Dake <sdake@xxxxxxxxxx> - 0.76-1.7 - Remove ExclusiveArch since all Fedora Core 6 arches have been tested. * Fri Jun 9 2006 Steven Dake <sdake@xxxxxxxxxx> - 0.76-1.6 - Move condrestart to %%postun instead of %%post. - Call initscript directly as suggested by Jesse. The new SRPM and specfile can be downloaded from: Spec URL: http://developer.osdl.org/dev/openais/SRPM/openais.spec SRPM URL: http://developer.osdl.org/dev/openais/SRPM/openais-0.76-1.7.src.rpm > -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review