Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kicad - Electronic schematic diagrams and printed circuit board artwork https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193531 ------- Additional Comments From cgoorah@xxxxxxxxxxxx 2006-06-12 15:01 EST ------- Hello, This is not a real official review, just a review from an intern packager. :) # 1 The rpmlint _does_ return warning/errors: chitlesh(i386)[0]$rpmlint -i kicad-2006-04-24-0-4.i386.rpm W: kicad-2006-04-24 incoherent-version-in-changelog 2006-04-24-0-4 0-4 Your last entry in %changelog contains a version that is not coherent with the current version of your package. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/pt/contents.hhc This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/fr/pcbnew/pcbnew.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 file-not-utf8 /usr/share/doc/kicad/en/pcbnew/doc_pcbnew.zip The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad-2006-04-24-0/author.txt This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/fr/kicad/kicad.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/en/cvpcb/cvpcb-en.pdf This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. E: kicad-2006-04-24 script-without-shellbang /usr/share/doc/kicad-2006-04-24-0/gpl.txt This executable text file does not contain a shebang, thus it cannot be properly executed. Often this is a sign of spurious executable bits for a non-script file, but can also be a case of a missing shebang. To fix this error, find out which case of the above it is, and either remove the executable bits or add the shebang. E: kicad-2006-04-24 wrong-script-end-of-line-encoding /usr/share/doc/kicad-2006-04-24-0/gpl.txt This script has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It will prevent its execution. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/en/pcbnew/pcbnew.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. E: kicad-2006-04-24 script-without-shellbang /usr/share/doc/kicad-2006-04-24-0/readme.txt This executable text file does not contain a shebang, thus it cannot be properly executed. Often this is a sign of spurious executable bits for a non-script file, but can also be a case of a missing shebang. To fix this error, find out which case of the above it is, and either remove the executable bits or add the shebang. E: kicad-2006-04-24 wrong-script-end-of-line-encoding /usr/share/doc/kicad-2006-04-24-0/readme.txt This script has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It will prevent its execution. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/en/contents.hhc This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad-2006-04-24-0/contrib.txt This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/fr/cvpcb/cvpcb.pdf This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/pt/pcbnew/pcbnew.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/en/eeschema/eeschema.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/pt/cvpcb/cvpcb-pt.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/es/contents.hhc This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/fr/cvpcb/cvpcb-fr.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/pt/eeschema/eeschema-pt.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/fr/eeschema/eeschema.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. E: kicad-2006-04-24 script-without-shellbang /usr/share/doc/kicad-2006-04-24-0/version.txt This executable text file does not contain a shebang, thus it cannot be properly executed. Often this is a sign of spurious executable bits for a non-script file, but can also be a case of a missing shebang. To fix this error, find out which case of the above it is, and either remove the executable bits or add the shebang. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/es/pcbnew/pcbnew-es.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/es/kicad/kicad-es.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/fr/contents.hhc This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/pt/kicad.hhp This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad-2006-04-24-0/doc_conv_orcad_to_kicad.txt This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. E: kicad-2006-04-24 script-without-shellbang /usr/share/doc/kicad-2006-04-24-0/licendoc.txt This executable text file does not contain a shebang, thus it cannot be properly executed. Often this is a sign of spurious executable bits for a non-script file, but can also be a case of a missing shebang. To fix this error, find out which case of the above it is, and either remove the executable bits or add the shebang. E: kicad-2006-04-24 wrong-script-end-of-line-encoding /usr/share/doc/kicad-2006-04-24-0/licendoc.txt This script has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It will prevent its execution. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/fr/file_formats/file_formats.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/pt/kicad/kicad-pt.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/es/eeschema/Eeschema_Chapter1_ES.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/en/kicad/kicad.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/en/kicad.hhp This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad-2006-04-24-0/doc_conv_orcad_to_kicad_spanish.txt This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/en/gerbview/gerbview.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/fr/eeschema/eeschema.pdf This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/es/eeschema/eeschema-es.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/es/cvpcb/cvpcb-es.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/pt/eeschema/eeschema.pdf This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/pt/kicad/kicad.pdf This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/es/gerbview/gerbview.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/pt/gerbview/gerbview.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/en/cvpcb/cvpcb-en.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/fr/gerbview/gerbview.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/en/file_formats/file_formats.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/pt/file_formats/file_formats.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/fr/kicad.hhp This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. E: kicad-2006-04-24 script-without-shellbang /usr/share/doc/kicad-2006-04-24-0/copyright.txt This executable text file does not contain a shebang, thus it cannot be properly executed. Often this is a sign of spurious executable bits for a non-script file, but can also be a case of a missing shebang. To fix this error, find out which case of the above it is, and either remove the executable bits or add the shebang. E: kicad-2006-04-24 wrong-script-end-of-line-encoding /usr/share/doc/kicad-2006-04-24-0/copyright.txt This script has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It will prevent its execution. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/es/file_formats/file_formats-es.html This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. W: kicad-2006-04-24 wrong-file-end-of-line-encoding /usr/share/doc/kicad/es/kicad.hhp This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. # 2. it is advisable to # 2.1 : name patches like Patch0: <NAME>-<VERSION>-<DESCRIPTION>.patch # 2.2 : replace %{_datadir}/locale/* by %find_lang %{name} and consequently %files -f %{name}.lang too. # 2.3 : add the following after %clean since you are using kicad.desktop -------- %post touch --no-create %{_datadir}/icons/hicolor || : %postun touch --no-create %{_datadir}/icons/hicolor || : --------- # 3 : I am not sure whether you can use this type of %{name} along with its date # 4 There is an incoherent-version-in-changelog which should be 0-4 instead of 2006-04-24-0-4 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review