Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ifd-egate https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194551 ------- Additional Comments From ville.skytta@xxxxxx 2006-06-11 11:30 EST ------- Created an attachment (id=130930) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130930&action=view) Suggested Makefile patch I don't have hardware to test this with, but here's some observations: - Cosmetic: placement of %post is somewhat unusual, it's usually after %clean - pcscd not restarted on final removal - $RPM_OPT_FLAGS not honored - The makefile hunk of the timing patch (which seems misplaced in this patch) defines USB_DRIVER_DIR which is unused. - USB_CFLAGS, USB_LDFLAGS, PCSC_LDFLAGS undefined - Unowned install directories - License is a bit unclear, both LGPL and BSD are included - "This should be installed with the base OS" sounds odd in the %description Attached is a suggested replacement for the Makefile hunk in the timing patch. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review