Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lat (LDAP Administration Tool) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177580 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gdk@xxxxxxxxxx |j.w.r.degoede@xxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-06-11 07:23 EST ------- MUST: ===== * rpmlint output is: E: lat hardcoded-library-path in /usr/lib E: lat no-binary E: lat only-non-binary-in-usr-lib All because this is a mono app, all ok. * Package and spec file named appropriately * Packaged according to packaging guidelines 0 License (GPL) ok, but license file noy included * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel-x86_64 * BR: ok * Locales properly handled * No shared libraries * Not relocatable 0 Package does not own all dirs (see Must fix below) * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only 0 no %doc * no -devel package needed, no libs / .la files. * .desktop file properly installed MUST fix: ========= * %post and %postun call update-desktop-database this is deprecated and must be removed. * no %doc, not even for COPYING! * unowned dirs: /usr/share/omf /usr/share/gnome /use/gnome/help, I know this is somwhat controversial, but lat doesnot depend on any packages which provide these dirs, so it should own them. Feel free to discuss this on f-e-l if you disagree. * /usr/pixmaps/lat.png must be moved to /usr/share/icons/hicolor/22x22/apps/ in %install and then the icon-cache should be properly updated in %post and %postun (see wiki scriptlets page). Should fix: =========== * in %install you write: # remove libtool archives /usr/bin/find %{buildroot}%{_libdir} -name '*.la' -exec %{__rm} -f {} \; This is a mono app, does it install .la files? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review