Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wormux - 2D Kill 'em all game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194436 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-06-09 18:06 EST ------- * rpmlint output okay: W: wormux-data no-documentation * Package is named according to package naming guidelines * spec file matches package %{name} * Package meets packaging guidelines * Package licensed with open source compatible license * License in spec file matches actual license * License text file included in %doc * Spec file written in American english * Spec file is legible * Sources match upstream source 08d897a89f06cb855709be2904308cac wormux-0.7.2.tar.gz * Package successfully compiles and builds on x86_64 FC-5 * All build dependencies are listed in BuildRequires - Except for pkgconfig which will be needed for FC-6 * No locales in package * Package does not make a shared library * Package is not relocatable * Package owns all directories it creates * Package does not contain duplicate files in %files * Permissions on files set properly * Package has appropriate %clean section - Macro usage is not consistant * Package contains permissible content * Package does not contain large documentation to warrent a -doc subpackage * Files in %doc do not affect runtime of application * Package does not contain header files or static libraries * Package does not contain any .pc files * Package does not contain any .so files * Package does not need a devel subpackage * Package does not contain any .la files * Package contains a nearly appropriate .desktop file - .desktop file missing Encoding section * Package does not own files or directories owned by other packages MUST: - Add pkgconfig to BuildRequires for FC6 builds - Add "Encoding" field to .desktop file - Use %{buildroot} consistantly, there is an $RPM_BUILD_ROOT adn %{buildroot} - Remove INSTALL from %files Notes: - Credits button doesn't seem to do anything, not sure if its broken or just not implemented yet. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review