Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-06-09 06:01 EST ------- Created an attachment (id=130806) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130806&action=view) Patch fixing tinyxml usage bug I've been testing cegui with Secret Maryo Chronicles yesterday (fungame, but I'm afraid its a bit to inspired/like the original to be packagable). While testing I've found a small (and known but not fixed judging from the comments GRRR) bug in the TinyXML calling code. This patch fixes this: About your -5 spin, looking good but: @@ -6889,7 +6889,7 @@ # are reset later if shared libraries are not supported. Putting them # here allows them to be overridden if necessary. runpath_var=LD_RUN_PATH - hardcode_libdir_flag_spec='${wl}--rpath ${wl}$libdir' + hardcode_libdir_flag_spec='${wl}$libdir' export_dynamic_flag_spec='${wl}--export-dynamic' # ancient GNU ld didn't support --whole-archive et. al. if $LD --help 2>&1 | grep 'no-whole-archive' > /dev/null; then That should be: + hardcode_libdir_flag_spec='' The old version would expand to: hardcode_libdir_flag_spec='-Wl,--rpath -Wl,$libdir' Which would cause gcc to call ld with: --rpath $libdir So both must be removed. Notice that there are multiple cases in the patch where you've got this wrong. Hint: in cases like this I often find it easier to just edit the patch then to generate a whole new one, just change the offending lines starting with a + without touching anything else. p.s. If you're interested in SMC let me know I've got some patches for some issues it has (send upstream too). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review