Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-06-07 11:04 EST ------- (In reply to comment #12) > I also think some of the includes probably need fixing in the devel package, and > I have my doubts as to whether CEGUI/renderers/IrrlichtRenderer/* should appear > in the devel package, seeing as we're not supporting Irrlicht. Since we don't support it I say either nuke that directory in %install or %exclude it on %files MUST: ===== * rpmlint output is: W: cegui-devel no-documentation No problem there * Package and spec file named appropriately * Packaged according to packaging guidelines * License (LGPL) ok, license file included * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel-i386 * BR: ok * No locales * ldconfig properly called for shared libraries * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime * seperate -devel-docs sub package for large development docs * proper -devel package as needed * .la files not packaged * no gui -> no .desktop file required MUST fix: ========= * in ScriptingModules/CEGUILua/LuaScriptModule/src/Makefile.in you add -llua -ltolua++ to a link command and in the belonging Makefile.am you don't you should also add this in the .am file so that the .in file gets properly regenerated if automake ever gets run. * I notice that -rpath is used in the same link command, -rpath is evil and should (normally) not be used. Please remove the use of "-rpath <path>" from this and other Makefiles. * The build bombed out on me the first time because I didn't have lua-devel installed. tolua++-devel should have a "Requires: lua-devel" in the specfile. I wanted to file a seperate bug for this but I can't file bugs against tolua++ as Bugzilla hasn't picked up the addition to owners.list (yet). (My fault I should have seen that in the review). Should fix: =========== * in %setup you write: cd ScriptingModules/CEGUILua/LuaScriptModule/package/ tolua++ -o ../src/lua_CEGUI.cpp CEGUI.pkg Why not just pass the full path as the second arg to tolua++? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review