Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sax2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187282 jpmahowald@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |jpmahowald@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-06-04 16:13 EST ------- Not building, same error. Add readline-devel to BuildRequires. /usr/share/locale is forbidden, use %find_lang Use python macros from fedora-rpmdevtools package to avoid hardcoding site-packages dir. Require the libX* package instead of the xorg implementation. Drop the PreReq, not needed. Probably most of Requires too, most of it is covered from library requirements brought in by BuildRequires. Why %define __perl_requires %{nil} ? This could use a comment. Need to use a lot more macros. Ideally, at least in my opinion, there are no /usr references anywhere in the spec. There are readability issues with the SuSE specific parts. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review