Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: knetstats https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193929 ------- Additional Comments From packages@xxxxxxxxxxxxxxxxxx 2006-06-04 14:54 EST ------- Not a formal review, but here's a few things I've noticed. 1. You should probably patch the SConstruct file to remove rpath from the environment. See 'env.KDEuse("environ rpath")' in the file. 2. Add -q to the %setup macro 3. Since you're using %{version} in the source tag, consider using the %{name} macro too. 4. Drop gcc-c++ from the buildrequires, see http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28CategoryExtras%29 5. Perhaps a matter of preference, but consider using the scons supplied with the source, ie drop the scons BR and use ./scons in the build section. 6. Use the %{?_smp_mflags} on the scons build line, to allow parallel building 7. The install process attempts to create files outside the buildroot: "mkdir: cannot create directory `/usr/share/doc/HTML/en/knetstats': Permission denied" This must be fixed. 8. The last changelog entry is missing its release number (im assuming it should have been -1) 9. To fix the desktop file, one solultion might be to delete the .desktop from the buildroot after scons install 'rm -f $RPM_BUILD_ROOT%{_datadir}/applnk/Internet/knetstats.desktop', then use desktop-file-install to install it yourself. Remember to add desktop-file-utils as a BR -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review