Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: renrot - A program to rename and rotate files according to EXIF tags https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193470 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-06-02 21:37 EST ------- rpmlint complains: E: renrot non-standard-executable-perm /usr/bin/renrot 0555 Should be 755. The only other issue is minor; BuildRequires: perl is not required. This is not a blocker. Since the only real issue is fixed up by a quick chmod, I'll go ahead and approve this and you can fix it when you check in. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: b3261caa8ed7a6c87add693310feb9b9 renrot-0.20.tar.gz b3261caa8ed7a6c87add693310feb9b9 renrot-0.20.tar.gz-srpm * latest version is being packaged. O BuildRequires are proper (BR: perl is redundant) * package builds in mock (development, x86_64). X rpmlint complains about mode 555 file. * final provides and requires are sane: config(renrot) = 0.20-1.fc6 renrot = 0.20-1.fc6 - /usr/bin/perl config(renrot) = 0.20-1.fc6 libjpeg >= 6b perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(Getopt::Long) perl(Image::ExifTool) perl(Time::Local) perl(Time::localtime) perl(strict) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. X file permissions are appropriate. * %clean is present. * %check is not present; no test suite upstream. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED, provided you fix the permissions on /usr/bin/renrot. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review