Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-sqlite3 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193071 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-06-02 15:59 EST ------- A couple of comments: The guidelines (which I think you wrote) use ruby_sitearchdir instead of ruby_sitearch. Not a big deal but I suppose we should try for consistency since these first few packages will stand as examples. You don't require a specific Ruby version. You manually strip the .so, which is a bad idea because it breaks the debuginfo package. (It ends up empty.) Everything is fine if you delete the call to strip. I'm guessing you saw an rpmlint warning about an unstripped binary; making it executable is sufficient it fix that. I wonder if we're any closer to getting fixed Ruby packages so that we can get the guidelines ratified. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review