Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: scite - Scintilla based text editor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193787 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-06-02 10:38 EST ------- The license seems to me to be equivalent to the MIT license (http://www.opensource.org/licenses/mit-license.php); that's what I'd use in the License: field. Some other comments: You don't seem to use %{optflags}; the package is compiled with -Os instead of the usual Fedora set (which includes FORTIFY_SOURCE and -g so that proper debuginfo packages can be generated). It seems that scintilla is built separately and then statically linked in. Is it reasonable at all to build in a separate package and then dynamically link it in? (Keep in mind that I know nothing about scintilla. It does seem that most of the packages that use scintilla seem to just include a copy of the source, which may be the best way to handle it.) Finally, I just wanted to make sure you understand that sponsorship is generally granted only after you've demonstrated familiarity with the packaging guidelines; generally you do this by commenting on other packages up for review. I personally am reluctant to sponsor someone after looking at just a single submitted package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review