Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: jaws https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187325 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|fedora-extras- |fedora-package- |list@xxxxxxxxxx |review@xxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-06-01 21:06 EST ------- I noticed that this review request had been inactive so I thought I'd give a quick look. Some simple things to fix: Release: 1.%{?dist} You should omit the dot; %{dist} includes a dot so you'll end up with two. rpmlint warnings: W: jaws summary-ended-with-dot A framework and content management system for building dynamic Web sites. Summary: should not end in a period. W: jaws incoherent-version-in-changelog 0.6.1-1 0.6.1-1..fc6 Not sure what's up here; perhaps it doesn't like the dot in Release:. E: jaws script-without-shellbang /var/www/jaws/plugins/AntiSpammers/languages/ro/AntiSpammers.php Lots of these (61, to be exact); I don't believe these PHP scripts, css files, xml files or javascript files should be executable. E: jaws wrong-script-end-of-line-encoding /var/www/jaws/plugins/AntiSpammers/languages/ro/AntiSpammers.php Lots of these as well (41); a quick trip through tr should fix them up. E: jaws version-control-internal-file /var/www/jaws/include/pear/MDB2/Driver/Function/CVS/Entries CVS directories and anything under them should just be deleted. E: jaws zero-length /var/www/jaws/include/Extras/piwi/piwidata/js/jscalendar/lang/calendar-af.utf8.js There are four zero-length files shipped: /var/www/jaws/include/Extras/piwi/piwidata/js/jscalendar/lang/calendar-af.utf8.js /usr/share/doc/jaws-0.6.1/NEWS /var/www/jaws/include/Extras/geshi/geshi/css-gen.cfg /var/www/jaws/include/Extras/piwi/piwidata/js/jscalendar/lang/calendar-af.js These shouldn't be included unless they're required for something. Other than these the package looks good. However, I don't see your address in owners.list, nor do I see anything that obviously matches your address in the accounts system. Do you require sponsorship? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review