Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: V2Strip ID3v2(Mp3 Files) tags remover https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192876 hugo@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hugo@xxxxxxxxxxxx ------- Additional Comments From hugo@xxxxxxxxxxxx 2006-05-31 14:26 EST ------- Review for this package: BLOCKERS: - Package in non-standard group (Applications/Shell), see: http://fedoraproject.org/wiki/RPMGroups - The application don't need the 'openssl-devel' BuildRequires. (Why?) - You must include the COPYING file in %doc's %files. It contains the license of the application (GPL). - ChangeLog should be in %doc too. SHOULD: - When creating a new specfile, the recommended way is to create using the following command: fedora-newrpmspec <package-name> - (Really minor) The arrangement in the specfile could be better. Spacing and these things. The 'fedora-newrpmspec' helps on this. You can look at other specs too. Just to get the specfile more organized and pretty :-) - (Really minor) Description is ok. Consider putting "v2strip is a ..." before the description field. Example: "v2strip is a little utility that removes ID3v2..." OKS: - Source package matches the package from upstream - Builds and works fine - Package name ok -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review