Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Net-Jabber https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191545 ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-05-29 19:13 EST ------- Some bad stuff from the test suite: t/2_client....................ok 4/5 skipped: Cannot open connection (maybe a firewall?) t/protocol_definenamespace....Cannot resolve compute20.math.uh.edu: at /usr/lib/perl5/vendor_perl/5.8.8/XML/Stream.pm line 406. # Looks like you planned 70 tests but only ran 1. # Looks like your test died just after 1. dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 2-70 Failed 69/70 tests, 1.43% okay t/protocol_muc................Cannot resolve compute20.math.uh.edu: at /usr/lib/perl5/vendor_perl/5.8.8/XML/Stream.pm line 406. # Looks like you planned 4 tests but only ran 1. # Looks like your test died just after 1. dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 2-4 Failed 3/4 tests, 25.00% okay t/protocol_rpc................Cannot resolve compute20.math.uh.edu: at /usr/lib/perl5/vendor_perl/5.8.8/XML/Stream.pm line 406. # Looks like you planned 19 tests but only ran 1. # Looks like your test died just after 1. dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 2-19 Failed 18/19 tests, 5.26% okay t/query_time..................ok 1/39 skipped: Time::Timezone not installed For that last one, you should add perl(Time::Timezone) to your BuildRequires: set. For the failing tests, your options are to disable those tests or to disable the entire test suite. Doing the latter would be a shame because there's plenty of test suite that can be run. Disabling the failing tests is easy: just add this at the beginning of %check: # Disable tests which will fail under mock rm t/protocol_definenamespace.t rm t/protocol_muc.t rm t/protocol_rpc.t I'll do this so that I can build and complete this review. Once built, rpmlint has some complaints: E: perl-Net-Jabber script-without-shellbang /usr/lib/perl5/vendor_perl/5.8.8/Net/Jabber/Dialback/Result.pm This is fixed by removing execute permission from that file. E: perl-Net-Jabber script-without-shellbang /usr/share/doc/perl-Net-Jabber-2.0/examples/component_test.pl E: perl-Net-Jabber script-without-shellbang /usr/share/doc/perl-Net-Jabber-2.0/examples/component_accept.pl W: perl-Net-Jabber doc-file-dependency /usr/share/doc/perl-Net-Jabber-2.0/examples/rpc_client.pl /bin/sh W: perl-Net-Jabber doc-file-dependency /usr/share/doc/perl-Net-Jabber-2.0/examples/rpc_server.pl /bin/sh Documentation should not be executable, so you need to remove execute permissions from these files as well. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * license field matches the actual licenses (as "clarified" by the author). * license is open source-compatible. License texts included in package. * source files match upstream: 1fd348fb9a1a6c5a167ae862ed89cd53 Net-Jabber-2.0.tar.gz 1fd348fb9a1a6c5a167ae862ed89cd53 Net-Jabber-2.0.tar.gz-srpm * latest version is being packaged. O BuildRequires are proper (BR: perl is on the exception list). O package builds in mock (development, x86_64) after disabling tests as above. X rpmlint is silent. X final provides and requires are sane (doc files pull in /bin/sh which should not be there). * no shared libraries are present. * package is not relocatable. owns the directories it creates. doesn't own any directories it shouldn't. no duplicates in %files. X file permission issues; some files are executable that shouldn't be. * %clean is present. O %check is present and all tests pass (once failing tests are disabled and perl(Time::Timezone is added to BR:): All tests successful, 4 subtests skipped. Files=46, Tests=3283, 33 wallclock secs (10.03 cusr + 2.15 csys = 12.18 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review