Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: streamer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193224 ------- Additional Comments From paul@xxxxxxxxxxxx 2006-05-29 11:48 EST ------- (In reply to comment #7) > I updated Release number and added a ChangeLog entry in it. Updated files are at > Spec URL: http://people.redhat.com/pnemade/Qcwebcam/streamer.spec > SRPM URL: http://people.redhat.com/pnemade/Qcwebcam/streamer-1.1-3.fc5.src.rpm Thanks. What appears to have happened now is that upstream (you) have released a new tarball at version 1.1 that contains the GPL file, which was not the case with the version 1.1 tarball I last looked at. *Please* don't release new tarballs with the same version numbers as previous releases - that's a really bad habit to get into. You've fixed the unowned directory by adding the following line to %files: %{_libdir}/streamer/ This tells RPM to include that directory and everything underneath it, which results in lots of "file included twice" warnings when the package is built. To avoid this, do either: %{_libdir}/streamer/ (which will include everything from that directory downwards), or %dir %{_libdir}/streamer/ plus all the individual files that you currently list in the %files section. The %dir tag tells RPM to include the directory but not its contents. The build process produces quite a lot of compiler warnings. Most of these can be ignored, but these warrant investigation I think: console/capture.c: In function 'movie_writer_stop': console/capture.c:528: warning: integer constant is too large for 'long' type console/capture.c:533: warning: integer constant is too large for 'long' type console/capture.c: In function 'movie_print_timestamps': console/capture.c:588: warning: integer constant is too large for 'long' type console/capture.c:588: warning: integer constant is too large for 'long' type console/capture.c: In function 'movie_grab_put_video': console/capture.c:624: warning: integer constant is too large for 'long' type In order to get sponsored, you will need to demonstrate to a potential sponsor that you are familiar with the Fedora Extras processes and standards. The best way of doing this is to review other people's packages. Doing this can also be a useful learning experience for yourself, as you're likely to pick up tips from other packages and review comments. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review