Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: VDR - Video Disk Recorder https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190343 ------- Additional Comments From enrico.scholz@xxxxxxxxxxxxxxxxxxxxxxxxx 2006-05-29 02:32 EST ------- Sorry for the delay... Comments: * you are writing | %{__patch} -i ... | ... | ... make ... | install ... For consistency, you should either use everywhere the '%__XXXX' macros, or everywhere only 'XXXX'. * the version in | BuildRequires: glibc-kernheaders >= 2.4-9.1.94 is unneeded; every target system has this version of the glibc-kernheaders package * you are placing files into an unowned directory; so (despite of the no-ordered-package-removal problem) the | Requires: udev should be | Requires(pre): udev | Requires(postun): udev (or '/etc/udev/rules.d' instead of 'udev') to guarantee that the directory exists before vdr files will be placed into it. * the vdr recordings might be shared between several machines. It would be nice when the generated UIDs/GIDs would be identical everywhere. So please use 'fedora-usermgt' for the 'vdr' user and 'video' group. * I am not sure about the 'vdr' username; three-letter usernames produce a high chance for conflicts with local usernames so I would avoid them and use e.g. 'vdrdaemon' instead of. On the other side, 'vdr' has some history and not using 'vdr' might cause other problems * ownership/location of the vdr configuration directory is another problem. I dislike the vdr:video owned /etc/vdr directory somehow because: * some configuration data is modified by the 'vdr' daemon (channels.conf, remote.conf, setup.conf) so it should be located in /var/lib/vdr * not all configuration data should be modifiable by the daemon (e.g. commands.conf) so permissions should should be root:video. * rpmlint generates lot of | E: vdr non-standard-uid ... vdr | E: vdr non-standard-gid ... vdr warnings which can be ignored. Ditto for | W: vdr non-conffile-in-etc /etc/sysconfig/vdr-plugins.d/README The | E: vdr zero-length /etc/vdr/setup.conf is related to the previous comment about the configuration files * I use the following tweak to the udev-rules to generates a predictable event device for the remote-control: | SUBSYSTEM=="input", SYSFS{../name}=="DVB on-card IR receiver", SYMLINK+="input/event-remote", GROUP="video", MODE="0660" This is valid for a Hauppauge Nexus-S; other cards will need another name. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review