Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-05-28 15:42 EST ------- (In reply to comment #2) > Thanks very much for the patch. I had to make a tiny change to it, because it > introduced the following trivial error: > > src/Makefile.am:151: noinst_HEADERS must be set with `=' before using `+=' > Ah, I didn't get that error because I removed ./bootstrap from %build. You should not call automake, aclocal, autoconf, etc (which ./bootstrap does) unless you've got a really good reason. If you do call them you should do so in %prep not %build. > Does this also apply to the private copy of lua include with the source > package? I suspect it probably does, although there's no shared libs in the FE > lua. Yes it does apply to lua and tinyxml too. I did notice lua but I forgot again. Even though lua as packaged only provides a .a file and not a .so file you should still use the system version during the build, it might contain Fedora specific fixes (for example for the always bleeding edge Fedora gcc version) and feel free to file a bug against lua asking for a .so instead of the .a . Since tinyxml isn't currently packaged we can leave that in, if you want todo something with regard to the xml code in cegui, it would prabably be best to convert to libxml or expat, we alreayd have more then enough xml libs as is. But as said, just leave it as is for now. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review