Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: <ocrad> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190090 ed@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: <ocrad> |Review Request: <ocrad> Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |ed@xxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From ed@xxxxxxx 2006-05-28 15:34 EST ------- Hi Krzysztof, here are a few items. Its not a complete review, its just what I could look at in the free time I had today: good: + source matches upstream + license is OK + no warnings or errors from rpmlint + no *.la files + no shared libs + appears to have propoer handling of info files needswork: - the license file should be included in %doc - the INSTALL file should not be in %doc - unfortunately, the buildsystem (configure && make) for ocrad is very minimal (its not based upon the Gnu autotools) and does not honor ${RPM_OPT_FLAGS}. Please patch Makefile.in so that you can use something like: export CXXFLAGS="$RPM_OPT_FLAGS" make in the spec-file -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review