Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qcwebcam https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193216 jpmahowald@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |jpmahowald@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-05-26 23:57 EST ------- Needs some work. * Use dist tag instead of coding release. http://fedoraproject.org/wiki/DistTag * Should install into /usr/bin, not /usr/bin/local - Does the Makefile have an install target? - need to substitute out paths with macros * URL tag missing, does it have a web page? * Source tag is not a URL * Should change Requieres to BuildRequires on the devel packges. For example ImageMagick-devel * Doesn't build, probably missing BuildRequires gtk2-devel * Need to handle the .desktop file correctly. http://fedoraproject.org/wiki/Packaging/Guidelines * %description should have "contains" not "contain" (Yes English is strange) And it is somewhat brief. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review