Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ctorrent - BitTorrent Client written in C https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192867 ------- Additional Comments From bdpepple@xxxxxxxxxxxxx 2006-05-26 20:02 EST ------- MD5Sums: 1bc787df91285a9cec8509617c3152d6 ctorrent-1.3.2.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Buildroot has all required elements * All necessary BuildRequires listed. * All desired features are enabled * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners * Package builds fine in Mock. * Package installs and uninstalls cleanly on FC5. Bad: * Group Tag is not from official list. http://fedoraproject.org/wiki/RPMGroups * Not all paths begin with macros. In the file section, '/usr/bin' should be replaced with '%{_bindir}'. Refer to http://fedoraproject.org/wiki/Extras/RPMMacros * We need to verify that the license is really GPL, since neither the tarball or the website mention the license at all. Minor: * rpmlint gives the following error, which is addressed in the first item of the Bad section: W: ctorrent non-standard-group Net * I wouldn't even bother to package the COPYING file, since it only contains the authors name and nothing else. The AUTHOR file contains the exact same information. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review