Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: poker-engine - Python library that implements poker rules https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191667 ------- Additional Comments From wart@xxxxxxxxxx 2006-05-26 16:11 EST ------- MUST ==== * rpmlint output: W: poker-engine-devel no-documentation This can be ignored since upstream doesn't provide developer documentation * Package and spec named appropriately * GPL license ok, license file included * Source matches upstream 23186d64a0ca1bcd22341355d6debc56 poker-engine-1.0.14.tar.gz * Spec file legible and in Am. English * No excessive BR: (though BR: rsync looks silly) * No Locales * No shared libs, headers, or libtool archives * pkgconfig file in -devel apckage * Not relocatable * No .desktop file needed * %{buildroot} cleaned where it ought to be * No duplicate %files * Builds in mock on FC4, FC5, and devel SHOULD ====== * Patch the configure script instead of running autoreconf in %prep QUESTIONS ========= * What's the difference between the xml files in /usr/share and /etc? MUSTFIX ======= * Missing Requires: rsync (for pokerconfigupgrade) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review