Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wifi-radar https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191507 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |tcallawa@xxxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From tcallawa@xxxxxxxxxx 2006-05-26 10:46 EST ------- There are a few minor issues with this package: - The package needs to properly handle its desktop file: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop Don't forget to include BuildRequires: desktop-file-utils - rpmlint throws some errors: W: wifi-radar conffile-without-noreplace-flag /etc/wifi-radar/wifi-radar.conf Might not be a bad idea to set this as %config(missingok,noreplace) to keep some other package from stepping on this config file. E: wifi-radar non-readable /etc/wifi-radar/wifi-radar.conf 0600 I'm pretty sure you didn't intend this. Or did you? E: wifi-radar non-standard-dir-perm /etc/wifi-radar 0700 Also a weird permission set for the config directory. E: wifi-radar non-standard-dir-perm /usr/share/doc/wifi-radar-1.9.6 0644 I don't see the reason to deviate from the standard %doc permission set, even though 644 is valid. Good items: - package meets naming guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR (except for desktop-file-utils) - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - %clean ok - macro use consistent - code, not content - no need for documentation subpackage - nothing in %doc affects runtime Show me a new spec with the minor blockers listed above resolved and I'll sponsor/approve. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review