Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: AGReader: Console reader for viewing AmigaGuide files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190390 ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-05-26 10:38 EST ------- Hmm, Before I do a full Review of this one here is a list of things to fix on forehand: 1) You write: # It is perhaps preferable to patch the source for compilation with gcc 4+ than # force compilation with gcc 3.2 as is done here Yes IMHO that is a must fix item, please write a patch so that it will compile with gcc-4.1 (and submit it upstream also please) and use that instead of this hack. If you find it hard to write this patch / encounter problems feel free to ask for help. I'm more the willing to write this patch for you when asked. 2) Inconsistent macro usage: "%{__rm} -rf %{buildroot}" in %cleanb instead use just "rm -rf %{buildroot}" as you do in %install. If you want to use %__cmd, you should use it everywhere, so also for make, install etc. But please don't :) Also I have doubts about the capitalization of the name, I thought it was prefered to use just lowercase, I've started a discussion about this on f-e-l. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review