Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rename of notify-daemon to notification-daemon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193191 ------- Additional Comments From bdpepple@xxxxxxxxxxxxx 2006-05-25 19:34 EST ------- Couple of items: 1. Fails to build in Mock. Looks like it is due to a missing BR on GConf2-devel. 2. The Requires on gtk2 & dbus are unnecessary, since the devel packages sonames will pull these in. 3. SOURCE should be a full URL. 4. You can probably pass the --disable-static flag to the configure macro, and not even build the static libs since your just removing them anyhow. 5. You should probably use the gconf scriptlets from the wiki. http://fedoraproject.org/wiki/ScriptletSnippets#head-ff64cd482595764f672082d5a3b83e1fc22962e8 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review