Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pari - Number Theory-oriented Computer Algebra System https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169703 ------- Additional Comments From gemi@xxxxxxxxxx 2006-05-25 17:35 EST ------- (In reply to comment #25) > - Don't need BR gzip and perl Ok. > - Why the Requires: gzip? I fact, gp can use gzip to load gzipped files, it seems. I moved the Requires to the gp subpackage. > - I would clean up some of the commented out stuff from the spec file, and the > unneeded Patch. Ok. > - rpmlint: > W: pari-gp devel-file-in-non-devel-package /usr/share/pari/examples/extgcd.c > this should probably be in the -devel package. The C example is in fact an example for a dynamic module loadable by gp. So it effectively belong to gp and not to devel. > > - The last sentence of the %description is odd, since this package contains the > library: I replace the last sentence by: "This package contains the shared libraries. The interactive calculator PARI/GP is in package %{name}-gp." > - Do we even care about pari.cfg? users.dvi mentions it, so I thought I leave it in the docdir. > - why not ship xgp and gpflog? I would not ship xgp. I just added a .desktop file to start gp in a terminal. I leave gpflog in. (In reply to comment #26) > Looks like: > > # we move pari.cfg to the docdir > rm -fr $RPM_BUILD_ROOT%{_libdir}/pari > > needs to be: > > # we move pari.cfg to the docdir > rm -fr $RPM_BUILD_ROOT%{_prefix}/lib/pari Ok. http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/pari-2.3.0-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review