Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openais standards based cluster framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192889 ------- Additional Comments From paul@xxxxxxxxxxxx 2006-05-25 05:15 EST ------- (In reply to comment #15) > The openais project doesn't allow CFLAGS to be overridden from Make. I think > this is an error upstream and will work to get it resolved and a new release > issued. Good; I had a quick look at the Makefile and I thought it was just adding to CFLAGS but I was mistaken. > I'll also get your other patches merged upstream. Thanks for the patches. No problem. > The problem you are having with the optflags is that -DOPENAIS_LINUX is not > being defined. > > A few questions about optflags... > > First how do I use rpmbuild to set the optflags like you have done so I can test > out the package build? > > Second, The code should compile with -O3 for performance reasons. But if > optflags is set to -O2 or less, how do I resolve this in the Makefiles? > > Here is what I am thinking. > > In the toplevel openais Makefile.inc, I will only add to the CFLAGS variable > instead of ever setting it directly. But this brings up the issue of a compile > with -O2 and -O3 both specified in the command line. Getting it to honor %optflags and use -O3 isn't too difficult actually, and can be done with a bit of sed trickery. Use this for the %build section of the spec: %build # The code should compile with -O3 for performance reasons CFLAGS="$(echo '%{optflags}' | sed -e 's/-O[0-9]*//') -O3 -DOPENAIS_LINUX" make CFLAGS="$CFLAGS" The spec file from Comment #12 modified in this way builds successfully in mock, at least on i386. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review