Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ctorrent - BitTorrent Client written in C https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192867 ------- Additional Comments From yaneti@xxxxxxxxxxx 2006-05-23 18:57 EST ------- More notes regarding 1.3.2-1: - the canonical sf source url used in most fedora specs is http://download.sourceforge.net/projectname/.. or http://dl.sf.net/projectname/.. so in this case http://download.sourceforge.net/ctorrent/ctorrent-1.3.2.tar.gz - you don't need the BuildRequires: rpm, see the section BuildRequires/Exceptions in the Packaging guidelines. It includes rpm-build which implies rpm. - you need a BuildRequires: openssl-devel - you don't need the Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1). All shared library dependencies are automatically generated by rpm. This includes openssl. See the "Requires" section in the Packaging guidelines. - the first line of your description still exceeds 80, please wrap it. - the secton Macros from the Packaging guidelines says "Use macros instead of hard-coded directory names (see Extras/RPMMacros)" which would mean %{_bindir}/ctorrent instead of /usr/bin/ctorrent in the files manifest When changing the spec in result of comments made in the review bump the Release tag and add an appropriate changelog so that there is some tracking of the review process. I can not officially review or sponsor this so thats all from me. Hope it helps. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review