Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: uuid https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192564 ------- Additional Comments From steve@xxxxxxxxx 2006-05-23 17:43 EST ------- (In reply to comment #1) > I think the license is essentially the MIT license: > http://www.opensource.org/licenses/mit-license.php > It's probably a better fit than "Distributable". OK. Fixed in -2. > rpmlint, as usual, finds something to complain about: > > E: uuid binary-or-shlib-defines-rpath /usr/bin/uuid ['/usr/lib64'] > W: uuid unstripped-binary-or-object /usr/lib64/libuuid.so.14.0.22 > W: uuid-c++ unstripped-binary-or-object /usr/lib64/libuuid++.so.14.0.22 > W: uuid-c++ no-documentation > W: uuid-dce unstripped-binary-or-object /usr/lib64/libuuid_dce.so.14.0.22 > W: uuid-dce no-documentation > W: uuid-dce-devel no-documentation > W: uuid-pgsql no-documentation > W: uuid-php no-documentation > > The no-documentation ones are OK. Agreed. > The unstripped object warnings are problematic; I don't know what to do about those. I don't either. I'm assuming the auto-strip magic is breaking for some reason, but I can't imagine what that reason is... > The rpath problem can be made to go away by adding: [libtool stuff] I tried that, but I still get the %{_libdir} rpath. Is that really an issue? I fixed a build directory rpath problem in the PHP module, BTW. Trying a similar fix for the %{_libdir} rpath thing (introduced, I'm 99% sure, by a -rpath in Makefile.in) results in a failed build. Well, actually, a failed install. Try adding "sed -i -e 's/ -rpath \$(libdir)//' Makefile.in" to %prep if you want to see what I mean. I might just be dense, but I don't see how to fix the problem. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review