[Bug 173459] Review Request: initng

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173459





------- Additional Comments From enrico.scholz@xxxxxxxxxxxxxxxxxxxxxxxxx  2006-05-20 05:34 EST -------
Blockers:

1. core package contains development files (*.so); write

   | %files
   | ...
   | /%{_lib}/lib*.so.*

   | %files devel
   | ...
   |  /%{_lib}/lib*.so

2. the

   | if [ -n "`ps -e|grep initng`" ]; then
   | 	/sbin/ngc --quiet -c >/dev/null 2>&1
   | fi

   in %post is

   a) ugly
   b) has missing Requires(post): grep procps
   c) contains one of the worst constructs in %scriptlets:

      | cmd 2>/dev/null

      which makes scriptlets fail silently without giving user a hint
      about the reason
   d) wrong because it will take non-init initngs into account

   The construct above should be replaced by

   | Requires(post): procps
   | ...
   | init=$(ps --no-headers -o '%%c' 1)
   | test x"$init" != xinitng || /sbin/ngc --quiet -c || :



Comments:

1. For bootstrapping in Extras, you can omit the

   | Requires: %{name} = %{version}-%{release}

   in -devel. Alternatively (I would prefer that), you should create a
   '-lib' subpackage with only the libraries and require this subpackage
   by -devel.

2. the

   | if [ -x /usr/sbin/semanage ]; then
   |      /usr/sbin/semanage fcontext -a -t init_exec_t /sbin/initng 2>/dev/null || :
   | fi

   can be expressed shorter as

   | /usr/sbin/semanage fcontext -a -t init_exec_t /sbin/initng 2>/dev/null || :


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]