Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: serpentine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191671 ------- Additional Comments From fedora.wickert@xxxxxxxx 2006-05-19 08:37 EST ------- Is there a particular reason not to use serpentine-0.6.91? http://developer.berlios.de/project/shownotes.php?group_id=3081&release_id=9269 0.6.91 introduces support for gstreamer-1.0 and fixes the issuse with the russian desktop.file and translations. Unfortunately German translations were dropped :(, maybe I'm going to update them. Attaching a patch. This patch also fixes the following issues: - own /usr/lib/python2.4/site-packages/serpentine and /usr/share/serpentine (comment #1) - drop python-abi Requires: (comment # 4) - drop serpentine-0.6.4-desktop.patch and use sed instead - description now ends with a dot: "...simplicity, usability and compatibility." BTW: IMHO description could be a little mor elaborate, something like: "Serpentine is an application for writing CD-Audio discs. It aims for simplicity, usability and compatibility and accepts a big range of audio (and video) formats thanks to the excelent GStreamer framework. It also tries to integrate well with other applications, accepting full Drag N Drop from applications like Nautilus, Rhythmbox and even Firefox." (parts taken from http://gnomefiles.org/app.php?soft_id=907) - require gstreamer-python instead of gstreamer08-python - remove-category X-Ximian-Main from fedora-serpentine.desktop A minor note: Calling update-desktop-database in post and postun was not necessary, because the desktop entry did not contain a mime type. 0.6.91 has a mime type, so we do need it now. Take what you need from my patch and update your package please. I'm going do do a complete review then. From what I've seen everything looks fine, package builds in mock and works well. I've successfully burned a couple of audio discs, in fact I'm using serpentine for a long time and rolled my own package. Nice to see somebody is willing to maintain it for extras. :-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review