Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: exiv2: Exif and Iptc metadata manipulation library and tools https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192124 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-05-17 15:40 EST ------- See below- Rpmlint output. OK - Package name. OK - Spec file name matches. OK - Package guidelines. OK - Licsense. (GPL) OK - License field matches in spec. OK - License included in files OK - Spec in american english OK - Spec legible OK - Md5sum of source from upstream 4c6593751368f5e9235d85e0d4058e67 exiv2-0.9.1.tar.gz 4c6593751368f5e9235d85e0d4058e67 exiv2-0.9.1.tar.gz.1 OK - Compiles and builds on one arch at least. (devel in mock) OK - No Forbidden buildrequires included OK - All required buildrequires included OK - Ldconfig in post/postun if including libs. OK - Owns all directories it creates. OK - No duplicate files in %files listing. See below - Permissions on files correct. OK - Clean section correct. OK - Macros consistant. OK - Code not content. OK - Docs must not affect runtime. OK - Header files/libs in a devel package. OK - .so files in devel package. OK - Devel package requires base package. OK - No .la files. OK - Doesn't own any files/dirs that are already owned by others. OK - Package builds in mock. See below - - Docs subpackage needed for large documentations. issues: 1. The description doesn't scan in some places. Might be reworked? Perhaps something like: -Exiv2 comprises of a C++ library and a command line utility to access image -metadata. Exiv2 supports full read and write access to th Exif and Iptc +Exiv2 consists of a C++ library and a command line utility to access image +metadata. Exiv2 supports full read and write access to the Exif and Iptc metadata, Exif MakerNote support, extract and delete methods for Exif thumbnails, classes to access Ifd and so on. -The command line utility allow you to: +The command line utility allows you to: * print the Exif metadata of Jpeg images as summary info, interpreted values, -or the plain data for each tag (here is a sample) +or the plain data for each tag * print the Iptc metadata of Jpeg images * print the Jpeg comment of Jpeg images * set, add and delete Exif and Iptc metadata of Jpeg images * adjust the Exif timestamp (that's how it all started...) * rename Exif image files according to the Exif timestamp -* extract, insert and delete Exif metadata, Iptc metadata and Jpeg comments -* extract, insert and delete the thumbnail image embedded in the Exif metadata +* extract, insert and delete Exif metadata (including thumbnails), +Iptc metadata and Jpeg comments 2. 2 lines of rpmlint output: W: exiv2 unstripped-binary-or-object /usr/lib/libexiv2-0.9.1.so Suggest: This file is mode 644, should be 755 so rpm can strip it/make proper debuginfo? E: exiv2 binary-or-shlib-defines-rpath /usr/bin/exiv2 ['/usr/lib'] Suggest: add --disable-rpath to configure? 3. Might be worth moving the /usr/share/doc/exiv2-devel-0.9.1/html/ to a -doc subpackage? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review