Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lvm2-cluster https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191200 ------- Additional Comments From jkeating@xxxxxxxxxx 2006-05-16 17:15 EST ------- Bad: - Buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Prereq should not be used. Use Requires(pre): instead. - Init file is not a %config file. Don't mark it as such. Indifferent: - Mixuse of %{_foo} style variable and $FOO variable. One should be used. Questions: - Why exclusive arch? Please list in spec file. - Why define _exec_prefix? _exec_prefix is an alias of _prefix, which is /usr. - --with-user= --with-group= Does that even work, non defined users? Also, I can't actually build this package because the deps aren't available in rawhide. Error: Missing Dependency: /lib/modules/2.6.16-1.2096_FC5 is needed by package dlm-kernel Error: Missing Dependency: kernel = 2.6.16-1.2096_FC5 is needed by package dlm-kernel Error: Missing Dependency: /lib/modules/2.6.16-1.2096_FC5 is needed by package cman-kernel Error: Missing Dependency: kernel = 2.6.16-1.2096_FC5 is needed by package cman-kernel -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review