Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: conntrack - Tool to manipulate netfilter connection tracking table https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186892 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-05-15 18:39 EST ------- Here's a review: OK - Rpmlint output. (none) OK - Package name. OK - Spec file name matches. OK - Package guidelines. OK - License (GPL) OK - License field matches in spec. OK - License included in files OK - Spec in american english OK - Spec legible OK - Md5sum of source from upstream 7491f914a9ebce180df88cbef0d994b3 conntrack-1.00beta1.tar.bz2 7491f914a9ebce180df88cbef0d994b3 conntrack-1.00beta1.tar.bz2.1 OK - Compiles and builds on one arch at least. (builds ok on devel, didn't use mock as not all requires are pushed out) OK - No Forbidden buildrequires included OK - All required buildrequires included OK - Owns all directories it creates. OK - No duplicate files in %files listing. OK - Permissions on files correct. OK - Clean section correct. OK - Macros consistant. OK - Code not content. OK - Docs must not affect runtime. OK - Doesn't own any files/dirs that are already owned by others. No blockers I can see... so this package is APPROVED. Remember to close this bug with NEXTRELEASE once you have imported and build the package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review