Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rsibreak https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189263 jpmahowald@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |jpmahowald@xxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From jpmahowald@xxxxxxxxx 2006-05-14 15:54 EST ------- - rpmlint checks return clean - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on FC5 (x86_64) - no missing BR - no unnecessary BR - locales handled properly - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file There really is not a much better rpm group. APPROVED I'll sponsor if still needed, apply for cvsextras. Note that when the package builds you can inform the rsibreak authors about the Extras package. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review