Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdiff3-0.9.88-1.src.rpm https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191473 laurent.rineau__fc_extra@xxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurent.rineau__fc_extra@nor | |malesup.org ------- Additional Comments From laurent.rineau__fc_extra@xxxxxxxxxxxxxx 2006-05-12 08:40 EST ------- Not a formal review, but I have several remarks: * MUST fix: Source0 URL should be http://dl.sourceforge.net/sourceforge/kdiff3/%{name}-%{version}.tar.gz * MUST fix rpmlint warnings and errors: W: kdiff3 summary-not-capitalized compare + merge 2 or 3 files or directories Easy to fix. E: kdiff3 standard-dir-owned-by-package /usr/share/icons E: kdiff3 standard-dir-owned-by-package /usr/share/man E: kdiff3 standard-dir-owned-by-package /usr/share/man/man1 See http://fedoraproject.org/wiki/Packaging/Guidelines, section "File and Directory Ownership". W: kdiff3 dangling-symlink /usr/share/doc/HTML/da/kdiff3/common /usr/share/doc/HTML/da/common W: kdiff3 dangling-symlink /usr/share/doc/HTML/de/kdiff3/common /usr/share/doc/HTML/de/common W: kdiff3 dangling-symlink /usr/share/doc/HTML/en/kdiff3/common /usr/share/doc/HTML/en/common W: kdiff3 dangling-symlink /usr/share/doc/HTML/et/kdiff3/common /usr/share/doc/HTML/et/common W: kdiff3 dangling-symlink /usr/share/doc/HTML/fr/kdiff3/common /usr/share/doc/HTML/fr/common W: kdiff3 dangling-symlink /usr/share/doc/HTML/it/kdiff3/common /usr/share/doc/HTML/it/common W: kdiff3 dangling-symlink /usr/share/doc/HTML/pt/kdiff3/common /usr/share/doc/HTML/pt/common W: kdiff3 dangling-symlink /usr/share/doc/HTML/sv/kdiff3/common /usr/share/doc/HTML/sv/common W: kdiff3 symlink-should-be-relative /usr/share/doc/HTML/da/kdiff3/common /usr/share/doc/HTML/da/common W: kdiff3 symlink-should-be-relative /usr/share/doc/HTML/de/kdiff3/common /usr/share/doc/HTML/de/common W: kdiff3 symlink-should-be-relative /usr/share/doc/HTML/en/kdiff3/common /usr/share/doc/HTML/en/common W: kdiff3 symlink-should-be-relative /usr/share/doc/HTML/et/kdiff3/common /usr/share/doc/HTML/et/common W: kdiff3 symlink-should-be-relative /usr/share/doc/HTML/fr/kdiff3/common /usr/share/doc/HTML/fr/common W: kdiff3 symlink-should-be-relative /usr/share/doc/HTML/it/kdiff3/common /usr/share/doc/HTML/it/common W: kdiff3 symlink-should-be-relative /usr/share/doc/HTML/pt/kdiff3/common /usr/share/doc/HTML/pt/common W: kdiff3 symlink-should-be-relative /usr/share/doc/HTML/sv/kdiff3/common /usr/share/doc/HTML/sv/common Seems to be a usual problem with KDE packages. I do not know what should be done. Kdiff3 version 0.9.89 has been release (2006-04-09). Perhaps you should update your tarball. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review