Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 ------- Additional Comments From wart@xxxxxxxxxx 2006-05-11 15:34 EST ------- On to the full review: rpmlint output: E: Maelstrom file-in-usr-marked-as-conffile /usr/games/Maelstrom/Maelstrom-Scores - This can be ignored E: Maelstrom non-standard-executable-perm /usr/bin/Maelstrom 02755 - This is ok per the Games SIG guidelines for scoreboard files E: Maelstrom standard-dir-owned-by-package /usr/share/icons - Change the %files line to %{_datadir}/icons/hicolor/48x48/apps/* W: Maelstrom buildprereq-use SDL-devel, SDL_net-devel E: Maelstrom broken-syntax-in-scriptlet-requires BuildPrereq: SDL-devel, SDL_net-devel - Change BuildPrereq: to BuildRequires: MUST ==== * Source matches upstream * Package and spec file named appropriately * spec file legible and in Am. English. * Builds in mock on: FC4-i386 FC4-x86_64 devel-i386 devel-x86_64 * No locales * No -devel package needed * No need for -docs subpackage * No shared libs * .dekstop file installed correctly MUSTFIX ======= * See rpmlint notes above * BR: SDL-devel is redundant. It's picked up by SDL_net-devel * License is GPL, not LGPL * License file is included in upstream tarball, but not in %doc * There is a questionable clause in the COPYING file: "The artwork and sounds used by Maelstrom are copyright Ambrosia Software (http://www.ambrosiasw.com) and may not be redistributed separately from the Maelstrom public GPL release." * Makefile and Makefile.in should not be included in /usr/share/Maelstrom/Images or %{_docdir}/Docs SHOULD ====== * The following is a nice shell trick, but would be more readable if each file were removed individually, one per line. rm -f $RPM_BUILD_ROOT%{_bindir}/{Maelstrom-netd,macres,playwave,snd2wav} ...change to... rm -f $RPM_BUILD_ROOT%{_bindir}/Maelstrom-netd rm -f $RPM_BUILD_ROOT%{_bindir}/macres (and so on) * The BuildRoot tag is almost there. From http://fedoraproject.org/wiki/Packaging/Guidelines: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review