Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: childplay_plugins - Plugins for childsplay (educational games for young children) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190878 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128837|0 |1 is obsolete| | ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-05-11 09:40 EST ------- Created an attachment (id=128885) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=128885&action=view) improved specfile (In reply to comment #4) > MUSTFIX > ======= > > * Source0: url points to the Sourceforge mirror selection page. Better > to use dl.sourceforge.net or hardcode a mirror so that tools like > spectool can be used to download the source files. (the same is true for > childsplay, which I failed to notice earlier) > Fixed > * 'yum remove childsplay childsplay_plugins' left two dangling directories > on the filesystem: > - /usr/share/childsplay/plugins > - /usr/share/childsplay/Data/icons > This is because yum removed childsplay before childsplay_plugins, and since > the directories weren't empty when childsplay was removed, and they weren't > owned by childsplay_plugins, they got left behind. > I've added: Requires(postun): /usr/share/childsplay/plugins Requires(postun): /usr/share/childsplay/Data/icons Which should enforce proper uninstall order. > SHOULD > ====== > * Even though upstream uses an underscore in the name, I think it's better > to use a dash '-' here. > Won't fix, this means that %{name} can't be used in the Source URL, and that I need to pass -n to %setup, etc. Now if upstreams name was really ugly I would find that worth the trouble but for this I would rather be consistent with what upstream uses. > * Request that upstream include the GPL license file in the tarball as they > already do for the base childsplay package. > Will do. ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-05-11 10:21 EST ------- Created an attachment (id=128892) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=128892&action=view) improved specfile (In reply to comment #4) > MUSTFIX > ======= > > * Source0: url points to the Sourceforge mirror selection page. Better > to use dl.sourceforge.net or hardcode a mirror so that tools like > spectool can be used to download the source files. (the same is true for > childsplay, which I failed to notice earlier) > Fixed > * 'yum remove childsplay childsplay_plugins' left two dangling directories > on the filesystem: > - /usr/share/childsplay/plugins > - /usr/share/childsplay/Data/icons > This is because yum removed childsplay before childsplay_plugins, and since > the directories weren't empty when childsplay was removed, and they weren't > owned by childsplay_plugins, they got left behind. > I've added: Requires(postun): /usr/share/childsplay/plugins Requires(postun): /usr/share/childsplay/Data/icons Which should enforce proper uninstall order. Unfortunatly this doesn't seem to work any bright ideas? > SHOULD > ====== > * Even though upstream uses an underscore in the name, I think it's better > to use a dash '-' here. > Won't fix, this means that %{name} can't be used in the Source URL, and that I need to pass -n to %setup, etc. Now if upstreams name was really ugly I would find that worth the trouble but for this I would rather be consistent with what upstream uses. > * Request that upstream include the GPL license file in the tarball as they > already do for the base childsplay package. > Will do. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review