Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: taskjuggler https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166470 ------- Additional Comments From petersen@xxxxxxxxxx 2006-05-11 08:35 EST ------- Thank you for the comments. (In reply to comment #5) > E: taskjuggler binary-or-shlib-defines-rpath /usr/bin/TaskJugglerUI > ['/usr/lib64', '/usr/lib64/qt-3.3/lib'] > > Try configure --disable-rpath Added. > W: taskjuggler devel-file-in-non-devel-package /usr/lib64/libtaskjuggler.so > > It's a symlink, no big deal Removed. > E: taskjuggler library-without-ldconfig-postin /usr/lib64/libtaskjuggler.so.3.0.3 > E: taskjuggler library-without-ldconfig-postun /usr/lib64/libtaskjuggler.so.3.0.3 Fixed. > * Missing SMP flags. If it doesn't build with it, please add a comment > (wiki: PackagingGuidelines#parallelmake) Added for now. > * No downloadable source. Please give the full URL in the Source tag. Fixed. > .desktop file needs some work, use desktop-file-install > * Desktop file: vendor should be fedora > (wiki: PackagingGuidelines#desktop) > * Scriptlets: missing update-desktop-database > (wiki: ScriptletSnippets) > * Desktop file: the Categories tag should contain X-Fedora > (wiki: PackagingGuidelines#desktop) > * Desktop file: the Categories tag should contain Application > (wiki: PackagingGuidelines#desktop) > * Scriptlets: missing "gtk-update-icon-cache" in %post (wiki: ScriptletSnippets) > * Scriptlets: missing "gtk-update-icon-cache" in %postun (wiki: ScriptletSnippets) Added. > The /usr/share/doc/HTML conflicts with Fedora's stuff, this and probably the > contents of packages/taskjuggler should be flagged with %doc instead. The location seems standard for KDE packages. I don't know if changing this would need require matching changes in source code too. > Any way to remove the .la file? Removed. Here is the updated submission: http://people.redhat.com/petersen/extras/taskjuggler.spec http://people.redhat.com/petersen/extras/taskjuggler-2.2.0-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review