Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpar2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190991 ------- Additional Comments From rc040203@xxxxxxxxxx 2006-05-09 13:22 EST ------- (In reply to comment #8) > Actually, here is a list of packages that include a generated config header, > on my FC-5¹: > Some come from FC-5 and other from FE-5. OT at this point - This is libpar2's review request. If you think the packages you listare broken, file individual PRs against them. But beware, your list seems to contain many false positives. > However, I agree that autoheaders should not be installed in the system. > Perhaps should we fill a bug report for these different packages. Exactly - But make sure to have understood the issue. The problem is NOT packages shipping generated headers, the problem is packages shipping autoheaders (headers generated by "autoheader"). > I am very willing to have libpar2 and gpar2 in FE. Can you explain what could > be a solution of a library that need autobuild tools to define some object > types and operations? Very hard to answer. AFAIS, libpar2 suffers from a fundamentally broken API. > libpar2 needs to know the endianess to define types > leu16, leu32, and leu64 (see letype.h). These three types are equal to > uint16_t, uint32_t and uint64_t, on little endian platforms, but are classes > with cast operations on big endian platforms. What mechanism could use libpar2 > to avoid installing autoheader, so that letype.h is correct? IMO, upstream should redesign the API (Keywords data abstraction/encapsulation). Somewhat less fundamentally, upstream should find a way to hard-code the defines it relies upon into an exported header, instead of letting its exported headers depend upon external programs. A very brutal, short-term workaround/hack would be to kick out par2cmdline.h and to replace it with a file using hard-coded values. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review