Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpar2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190991 ------- Additional Comments From rc040203@xxxxxxxxxx 2006-05-09 00:14 EST ------- (In reply to comment #6) > It's simply a case of "this package's sources are broken and need to be > reworked to be functional". Let me demonstrate the bug: cat par2bug.cc #include <libpar2/libpar2.h> // Fake using an autoheader #if HAVE_CONFIG_H #define PACKAGE_NAME foo #endif int main() { } 1) # g++ -o par2bug -DHAVE_CONFIG_H -I. $(pkg-config --cflags sigc++-2.0) \ $(pkg-config --libs sigc++-2.0) -lpar2 par2bug.cc In file included from /usr/include/libpar2/libpar2.h:5, from par2bug.cc:1: /usr/include/libpar2/par2cmdline.h:66:20: error: config.h: No such file or directory => par2cmdline.h expects the package using libpar2 to provide config.h 2) # g++ -o par2bug -DHAVE_CONFIG_H -I. $(pkg-config --cflags sigc++-2.0) \ $(pkg-config --libs sigc++-2.0) -lpar2 -I/usr/lib/libpar2/include par2bug.cc par2bug.cc:4:1: warning: "PACKAGE_NAME" redefined In file included from /usr/include/libpar2/par2cmdline.h:66, from /usr/include/libpar2/libpar2.h:5, from par2bug.cc:1: /usr/lib/libpar2/include/config.h:98:1: warning: this is the location of the previous definition => clash on autoheader define PACKAGE_NAME -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review