[Bug 189151] Review Request: xsp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xsp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151





------- Additional Comments From bdpepple@xxxxxxxxxxxxx  2006-05-08 17:35 EST -------
MD5Sums:
58facfdb9d13d48f9e8ad5069500081d  xsp-1.1.13.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed
* Builds fine in Mock.

Bad:
* The Group tag should probably reflect the same group as Apache (System
Environment/Daemons), since it is a web server.
* You have ownership problems with some of your directories that must be fixed.
* The %clean section is missing.
* Produces the following rpmlint errors:
W: xsp incoherent-version-in-changelog 1.1.13-1 1.1.13-2
E: xsp no-binary
E: xsp only-non-binary-in-usr-lib
E: xsp script-without-shellbang /usr/lib/xsp/2.0/asp-state2.exe.config
W: xsp devel-file-in-non-devel-package /usr/lib/pkgconfig/xsp-2.pc
E: xsp standard-dir-owned-by-package /usr/share/man/man1
E: xsp script-without-shellbang /usr/lib/xsp/2.0/dbsessmgr2.exe.config
E: xsp script-without-shellbang /usr/lib/xsp/1.0/asp-state.exe.config
W: xsp devel-file-in-non-devel-package /usr/lib/pkgconfig/xsp.pc
E: xsp script-without-shellbang /usr/lib/xsp/1.0/dbsessmgr.exe.config
W: xsp one-line-command-in-%post /sbin/ldconfig
W: xsp one-line-command-in-%postun /sbin/ldconfig

In particular, the 'standard-dir-owned-by-package' must be fixed.  Also, the
ChangeLog error must be corrected.  The scriptlets for the shared libraries are
unnecessary, since as far as I can tell this package doesn't contain any.  Most
of the others can be ignored, since it is a mono package.
 

Minor:
* The 'rm -rf ${RPM_BUILD_ROOT}' in the %prep section is unnecessary.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]