Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mondo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187318 ------- Additional Comments From bruno.cornec@xxxxxx 2006-05-08 10:05 EST ------- (In reply to comment #1) > 1. Don't use all the macros at the top of your spec, it just makes it harder to > do any qa on. Well, as I explained already in the mindi package, I have a build system to create .spec already in place. I'll see if I can do better, but for now these macros are useful for multirpm distro support (aka mandriva + suse + rhel + sles) > 2. Drop the additional languages from the spec. Why that ? Is fedora becoming an english only distro ? there are billions of people not speaking english, and for them having the possibility to read something else that english is useful no ? To be honest those rpms exist nearly since the begining of the project, and nobody never complained on that before, so I'm really surprised. > 3. Missing ChangeLog. My fault, will redeliver and add it. Corrected in SVN. > 4. You using a non-standard Group. Corrected in SVN. > 5. Duplicate BuildRequires: slang-devel (provided by newt-devel) I don't see the point here: # rpm -q slang-devel --provides slang-devel = 2.0.5-5.2.1 # rpm -q newt-devel --provides newt-devel = 0.52.2-5.2 What do you mean by duplicate ? Thanks for your answer, Bruno. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review