Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpar2 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190991 ------- Additional Comments From rc040203@xxxxxxxxxx 2006-05-08 05:00 EST ------- Some comments: 1. Minor issues: 1.1 # rpmlint *RPMS/libpar*.rpm E: libpar2-debuginfo script-without-shellbang /usr/src/debug/libpar2-0.2/galois.h E: libpar2-debuginfo script-without-shellbang /usr/src/debug/libpar2-0.2/par2repairersourcefile.cpp E: libpar2-debuginfo script-without-shellbang /usr/src/debug/libpar2-0.2/par2repairer.cpp E: libpar2-debuginfo script-without-shellbang /usr/src/debug/libpar2-0.2/par2repairersourcefile.h E: libpar2-debuginfo script-without-shellbang /usr/src/debug/libpar2-0.2/par1repairer.cpp E: libpar2-devel only-non-binary-in-usr-lib Most of these probably are caused by bogus permissions on source files. 1.2 Empty directory /usr/lib/libpar2 Is this package supposed to take plugins, there? 2. Major: This package's configuration (configure.ac/Makefile.am) is bugged: - configure.ac uses PKG_CHECK_MODULES(..sigc++..) but doesn't propagate the results to Makefile.am. Instead the Makefile explicitly links against -lstdc++. This violates g++'s working principles. Linking against -lstdc++ is a g++ internal detail. 3. Severe (Blocker): The package installs an autoheader (config.h) to a public directory (/usr/lib/libpar2/include/config.h). This file's contents will clash with other package's config headers and is a severe (must fix) design flaw of this package. A package must not install an autoheader. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review