Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Test-Base https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190705 jpo@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpo@xxxxxxxxxxxx ------- Additional Comments From jpo@xxxxxxxxxxxx 2006-05-07 23:12 EST ------- I've some reservations about the approval of this module. It appears to have several optional/missing Requirements and BR. BR: Text::Diff, YAML Req: Text::Diff, LWP::Simple, YAML I think we should at least BuildRequires: perl(Text::Diff) and Requires: perl(Text::Diff), perl(LWP::Simple) Note: IIRC the new version of YAML requires Test::Base => may cause circular dependencies problems. Note2: It's 4:00am. I will give another look at this module in a few hours. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review